Fixed a locale-dependent floating point parsing in the URDF parser. #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mass in the <inertial> tag was parsed with a locale-dependent function.
|
Added releases notes in cb646a1 . |
traversaro
changed the title
|
And I even thought about it! |
francesco-romano
changed the title
traversaro
approved these changes
Sep 7, 2018
|
From the CMake point of view, this is good to go. @francesco-romano are you ok with merging? We can add the missing header to the installed headers also in a different PR. |
|
Yes. We can add those in the other open PR (which I need to fix) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mass in the tag was parsed with a locale-dependent function.
This is my fault. I forgot the old function. I changed it back to the
iDynTreefunction (so when we will migrate to the new C++ locale independent function we have only one function to change).