Added compatibility with SWIG 2.0 #476
Conversation
|
I didn't updated the tests. I will do as soon as I have some time. |
I think not installing it was my error. Let's install it, and remove the bindings in the next iDynTree feature release (that may be a major version, if we want to follow SemVer). |
There was a problem hiding this comment.
I am not sure, but with this modifications the Span is visible just when SWIG_VERSION is defined, that is not the case for normal builds.
I guess we should modify all the #if conditions to have the following form:
#if !defined(SWIG_VERSION) || SWIG_VERSION >= 0x030000
|
If you are interested in having SWIG 2.0 compatibility in future feature releases, I think it is imperative to add a SWIG 2.0 to Travis, otherwise we will for sure break it again. Fortunately there is still a Note: SWIG 2.0 is the reason why we cannot use directly the |
francesco-romano
force-pushed
the
fix/swig2_compatibility
branch
from
c4aad59
to
aa25a70
Compare
|
Added the missing headers and fixed the swig 2 define. I did not touch travis though. |
|
No problem, that is more a concern for future releases, let's discuss f2f (more and less) and then I can handle that. |
traversaro
changed the title
CMakeLists.txt
Outdated
| @@ -25,7 +25,7 @@ set(VARS_PREFIX "iDynTree") | |||
|
|
|||
| set(${VARS_PREFIX}_MAJOR_VERSION 0) | |||
| set(${VARS_PREFIX}_MINOR_VERSION 11) | |||
| set(${VARS_PREFIX}_PATCH_VERSION 1) | |||
There was a problem hiding this comment.
I was thinking to stick to patch version 1 because I still need to release 0.11.1 .
francesco-romano
force-pushed
the
fix/swig2_compatibility
branch
from
5d8861c
to
aa25a70
Compare
|
Ok, commit dropped |
Removed
Spanfrom the bindings if SWIG < 3.0I marked the PR as WIP as we still have to decide what to do with some deprecated headers in
idyntree-modelio-urdf.@traversaro should we remove from the bindings
URDFGenericSensorsImport.h?