Change compatibility of CMake config files from SameMajorVersion to AnyNewerVersion #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nyNewerVersion Even if in the future major version can be breaking, for the main classes it would be relativly easy to have a codebase that is compatible with multiple iDynTree major versions. For this reason, I think it make sense to switch the CMake policy to `AnyNewerVersion` . If any downstream user wants to use a different policy, it can always manually check inspect the `iDynTree_VERSION` CMake variable.
|
Indeed, this problem broke the superbuild build: robotology/robotology-superbuild#328 . |
This was referenced Jan 14, 2020
GiulioRomualdi
approved these changes
Jan 14, 2020
This was referenced Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if in the future major version can be breaking, for the main classes it would be
relatively easy to have a codebase that is compatible with multiple iDynTree major versions.
For this reason, I think it make sense to switch the CMake policy to
AnyNewerVersion.If any downstream user wants to use a different policy, it can always manually check inspect the
iDynTree_VERSIONCMake variable.