-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add begin/end member functions for iDynTree vectors #646
Add begin/end member functions for iDynTree vectors #646
Conversation
Thanks for the contribution @GiulioRomualdi ! Technically this is a (small) new feature, so I would prefer to merge it in However, as it is the "saturday that is made for the men, not the men for the saturday", i.e. we follow guidelines only if we gain advantage from them, not because they are valuable on its own, if you have any reason why you want this in master let me know, thanks! |
Hi @traversaro. Devel is fine! |
Just to clarify, now that I cleaned up a bit the release process of iDynTree, I think if we need a iDynTree 1.1 we can easily release it when we need it, without waiting years. : ) |
Perfect, then feel free to change the target branch. |
ad5fb9b
to
af63dc7
Compare
Rebased on top of devel |
As for future reference,
it is Gospel of Mark, 2:27. I had to google for it, I believed it was actually Gospel of Mathew. |
af63dc7
to
559b167
Compare
Thanks! |
Sorry for the late comment. Was there a reason not to use an |
What do you think @GiulioRomualdi ? Until we actually release iDynTree 1.1, we can change the interface any time we want, so feel free to propose a change if you see fit. |
|
To be honest I did not know. Apparently the alternative is simply to define your own iterator without inheriting from |
This PR:
begin()/end()
andcbegin()/cend()
methods forVectorFixSize
begin()/end()
andcbegin()/cend()
methods forVectorDynSize
CHANGELOG.md
The implementation of these members will allow the user to use range-based for loop.
Related issue #645