Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuration and compilation against assimp 5 #661

Merged
merged 6 commits into from
Apr 1, 2020
Merged

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Apr 1, 2020

assimp 5 does not export the same CMake variables as assimp 4, so it is necessary to change the CMake commands to link with assimp depending on the assimp version used.

For reference, this are the CMake config for assimp 5 and 4:

This PR also:

  • Fixes the cmake package name of assimp, that is not ASSIMP , but always assimp .
  • Enables testing against assimp in macOS and Windows in GitHub Actions
  • Release v1.0.3 that contains the hot fix of compatibility with Assimp 5.

Fix #601

assimp 5 does not export the same CMake variables as assimp 4,
so it is necessary to change the CMake commands to link with
assimp depending on the assimp version used.
@traversaro traversaro requested a review from lrapetti April 1, 2020 14:43
@traversaro
Copy link
Member Author

Unfortunately this fixes the compilation just with the vcpkg-generated assimp, so it only fixes #601 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vcpkg-provided assimp does not work
2 participants