CI: Enable tests on Ubuntu 20.04 #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @GiulioRomualdi this probably means we can remove the valgring suppressions from BLF that were added in ami-iit/bipedal-locomotion-framework#61 . |
GiulioRomualdi
approved these changes
Nov 4, 2020
There was a problem hiding this comment.
@traversaro, do we know which dependency was causing the problem?
Based on the suppression that you added in https://github.com/dic-iit/bipedal-locomotion-framework/pull/61/files#diff-bf998516bf18ca9bdcaf4528db2c976d8189bd136104d31d34766bc85488f98e, I guess it could be a problem in the used blas (openblas is historically quite problematic w.r.t. to that) or a false positive due to a bug in a valgrind, but it is hard to guess now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently the test failures (valgrind for Ipopt and Octave) in #694 probably were due to problems in our dependencies that were fixed.