Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frame export for multi-root models. #914

Merged
merged 3 commits into from
Sep 1, 2021

Conversation

francesco-romano
Copy link
Collaborator

Do not export frames if corresponding link is not in the traversal.
This can happen if the model has links (and frames attached to those links) that
are not present in the exported traversal.

@CLAassistant
Copy link

CLAassistant commented Aug 31, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ traversaro
❌ francesco-romano
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@traversaro traversaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the fix seems nice. I just changed a bit the changelog style to match the rest of the document.

@traversaro
Copy link
Member

There seems to be a memory-related error of some kind.

Do not export frames if corresponding link is not in the traversal.
This can happen if the model has links (and frames attached to those links) that
are not present in the exported traversal.
@francesco-romano
Copy link
Collaborator Author

I am not sure if the fix worked. Can you please take a look at it?

@traversaro
Copy link
Member

I am not sure if the fix worked. Can you please take a look at it?

The tests are green it seems, so it seems fine.

@traversaro traversaro merged commit 7fc632c into robotology:master Sep 1, 2021
@traversaro traversaro deleted the fix/export_frames branch September 1, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants