Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI pipeline with Github Actions #30

Merged
merged 3 commits into from
May 14, 2020

Conversation

GiulioRomualdi
Copy link
Member

No description provided.

cd build
cmake ..
cmake --build . --config Release --target INSTALL
SET Eigen3_DIR=C:/Program Files (x86)/Eigen/lib/cmake/eigen3/
Copy link
Member

@diegoferigo diegoferigo Oct 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: if you pass shell: bash the shell is Git Bash and you can use familiar commands also on windows

@S-Dafarra
Copy link
Collaborator

I guess we do need this 😁

@GiulioRomualdi GiulioRomualdi changed the base branch from master to devel May 14, 2020 10:37
@GiulioRomualdi GiulioRomualdi force-pushed the feature/add-github-action-ci branch 2 times, most recently from c627cf1 to bb6361f Compare May 14, 2020 10:59
@GiulioRomualdi
Copy link
Member Author

On windows is still failing with the following error

2020-05-14T10:42:58.3914037Z D:\a\osqp-eigen\osqp-eigen\tests\MPCTest.cpp(75,14): error C2065: 'M_PI': undeclared identifier [D:\a\osqp-eigen\osqp-eigen\build\tests\MPCUnitTests.vcxproj]

even if I added

#define _USE_MATH_DEFINES
#include <cmath>

Do you have any hints? @S-Dafarra @traversaro

@GiulioRomualdi GiulioRomualdi force-pushed the feature/add-github-action-ci branch 2 times, most recently from 779a10b to ca8c1ba Compare May 14, 2020 11:25
@traversaro
Copy link
Member

traversaro commented May 14, 2020

On windows is still failing with the following error

2020-05-14T10:42:58.3914037Z D:\a\osqp-eigen\osqp-eigen\tests\MPCTest.cpp(75,14): error C2065: 'M_PI': undeclared identifier [D:\a\osqp-eigen\osqp-eigen\build\tests\MPCUnitTests.vcxproj]

even if I added

#define _USE_MATH_DEFINES
#include <cmath>

Do you have any hints? @S-Dafarra @traversaro

Either the math.h or cmath header has been transitively included by the headers included before the line that defines _USE_MATH_DEFINES in that compilation unit. To fix this, either move the definition of _USE_MATH_DEFINES before any other include, or pass it via command line (i.e. via CMake's target_compile_definitions).

@GiulioRomualdi GiulioRomualdi force-pushed the feature/add-github-action-ci branch 3 times, most recently from 9c4c728 to 0a4326d Compare May 14, 2020 12:27
@GiulioRomualdi GiulioRomualdi merged commit 4728e50 into devel May 14, 2020
@GiulioRomualdi GiulioRomualdi deleted the feature/add-github-action-ci branch May 14, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants