Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spelling #78

Merged
merged 3 commits into from
Dec 4, 2020
Merged

Fix spelling #78

merged 3 commits into from
Dec 4, 2020

Conversation

kalj
Copy link
Contributor

@kalj kalj commented Dec 3, 2020

No description provided.

@S-Dafarra
Copy link
Collaborator

S-Dafarra commented Dec 3, 2020 •
edited
Loading

Oh, thanks for catching! Instead of simply removing the old version, can you deprecate the old version (using the c++14 deprecated attribute) instead?

@kalj
Copy link
Contributor Author

kalj commented Dec 3, 2020

Oh, thanks for catching! Instead of simply removing the old version, can you deprecate the old version (using the c++14 deprecated attribute) instead?

Ah, I see. Sure.

@S-Dafarra
Copy link
Collaborator

We can wait for the CI to finish and, if @GiulioRomualdi agrees, we can merge.

@GiulioRomualdi GiulioRomualdi merged commit 553d11a into robotology:master Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traversaro traversaro traversaro left review comments

@S-Dafarra S-Dafarra S-Dafarra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kalj @S-Dafarra @traversaro @GiulioRomualdi