-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add boost as vcpkg dependency #7
Comments
Which ports in particular? Given that the users can install their own ports after unzip the binary archive provided here or the vcpkg installation under
However, in the meanwhile for CI I suggest you to use the existing binary archive (as done in https://github.com/robotology/robotology-superbuild/blob/master/.github/workflows/ci.yml#L96) so that you don't need to compile heavy ports such as
By the way, for smart ptr there is any reason why the boost data structures instead of the equivalent one supported in standard C++ since C++11? |
This is subject to change when/if |
I think that
We should use the standard one, this component should be not necessary thou. |
Sorry, I was not clear. If you follow the link https://github.com/robotology/blocktest/search?p=2&q=boost&type= by inspecting the source code is seems that all the one that I listed seems to be necessary.
Apparently that is not the case: https://github.com/robotology/blocktest/blob/ca4b4cfc39bf63ad008bdcede94cf7d3ecca21ed/src/blocktestrunner/connection.cpp#L6 . |
@traversaro here is the list of vcpkg that
|
@Nicogene @pattacini @vtikha How do you want to proceed with this request? We can try to do it in time for 2020.05, or delay it to after 2020.05 to target 2020.08 . |
I've no particular opinion on that. We could include it if there's time left. |
Adding it is not particular time consuming, I can easily do it while I updated the repo for trying to fix the Qt5 issues (robotology/robotology-superbuild#354). If we all agree on adding them, I can do it with no problems. |
Fine with me then 👍 |
In particular: * Use a recent commit of vcpkg, microsoft/vcpkg@28ab0b1 that contains microsoft/vcpkg#10644 * Update qt5 to build with the `latest` feature, that install qt 5.14 that should be the first version of qt completely relocatable ( https://www.qt.io/blog/qt-is-relocatable ) * Substitute opencv3 with opencv, that install opencv4 * Install also `asio`, `boost-asio`, `boost-process`, `boost-dll`, `boost-filesystem` and `boost-system`, to fix #7 * As the newer version of vcpkg are affected by the bug microsoft/vcpkg#10119, clone the `robotology-vcpkg-binary-ports` repo in `C:/robotology`, so that it will be contained in the same archive used to distribute the vcpkg dependencies .
I agree adding it in the 2020.05 release if it is not a big deal |
This is already part of #14 . The PR is a bit "fat" because the CI time is quite big and so I preferred to but a few changes together, but if you could review we are good to go. |
* Update to recent vcpkg version In particular: * Use a recent commit of vcpkg, microsoft/vcpkg@28ab0b1 that contains microsoft/vcpkg#10644 * Update qt5 to build with the `latest` feature, that install qt 5.14 that should be the first version of qt completely relocatable ( https://www.qt.io/blog/qt-is-relocatable ) * Substitute opencv3 with opencv, that install opencv4 * Install also `asio`, `boost-asio`, `boost-process`, `boost-dll`, `boost-filesystem` and `boost-system`, to fix #7 * As the newer version of vcpkg are affected by the bug microsoft/vcpkg#10119, clone the `robotology-vcpkg-binary-ports` repo in `C:/robotology`, so that it will be contained in the same archive used to distribute the vcpkg dependencies .
In particular: * Use a recent commit of vcpkg, microsoft/vcpkg@28ab0b1 that contains microsoft/vcpkg#10644 * Update qt5 to build with the `latest` feature, that install qt 5.14 that should be the first version of qt completely relocatable ( https://www.qt.io/blog/qt-is-relocatable ) * Substitute opencv3 with opencv, that install opencv4 * Install also `asio`, `boost-asio`, `boost-process`, `boost-dll`, `boost-filesystem` and `boost-system`, to fix robotology#7 * As the newer version of vcpkg are affected by the bug microsoft/vcpkg#10119, clone the `robotology-vcpkg-binary-ports` repo in `C:/robotology`, so that it will be contained in the same archive used to distribute the vcpkg dependencies .
It is possible to add
boost
as vcpkg dependency?The project where it is needed is https://github.com/robotology/blocktest.
The text was updated successfully, but these errors were encountered: