Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cppad to the compiled ports #37

Merged
merged 3 commits into from
Dec 9, 2020

Conversation

GiulioRomualdi
Copy link
Member

@GiulioRomualdi GiulioRomualdi commented Nov 26, 2020

This PR adds cppad to the compile ports. This will simplify the porting of bipedal-locomotion-framework in the robotology superbuild robotology/robotology-superbuild#526

@traversaro
Copy link
Member

I forgot to migrate away from add-path and the related commands apparently.

@GiulioRomualdi
Copy link
Member Author

I forgot to migrate away from add-path and the related commands apparently.

Done in 9eea746 Do you prefer I open a separate PR?

@traversaro
Copy link
Member

Could it make sense to also add casadi?

@traversaro
Copy link
Member

I forgot to migrate away from add-path and the related commands apparently.

Done in 9eea746 Do you prefer I open a separate PR?

Given the time taken for CI, I think that one PR is fine.

@traversaro
Copy link
Member

qhull from vcpkg could be useful as well?

@GiulioRomualdi
Copy link
Member Author

GiulioRomualdi commented Nov 26, 2020

Could it make sense to also add casadi?

Well I'm actually a bit skeptical about that. Casadi can be compiled with several options (for instance enabling osqp) Here we do not have some dependencies

qhull from vcpkg could be useful as well?

If I'm not mistaken qhull on vcpkg is broken (regarding find_package stuff)

@traversaro
Copy link
Member

Could it make sense to also add casadi?

Well I'm actually a bit skeptical about that. Casadi can be compiled with several options (for instance enabling osqp) Here we do not have some dependencies

It make sense, probably we should first have osqp as a port in vcpkg, and then to that.

@traversaro
Copy link
Member

@GiulioRomualdi I am quite happy that all the CI worked at the first try, but unfortunately I realized that you added cppad to the wrong list, the dependencies of Gazebo, not in the dependencies of the robotology-superbuild (that is earlier).

@GiulioRomualdi
Copy link
Member Author

@GiulioRomualdi I am quite happy that all the CI worked at the first try, but unfortunately I realized that you added cppad to the wrong list, the dependencies of Gazebo, not in the dependencies of the robotology-superbuild (that is earlier).

Oh no 😢

@GiulioRomualdi
Copy link
Member Author

@traversaro let me know if you're fine with the PR

@traversaro
Copy link
Member

@traversaro let me know if you're fine with the PR

Sorry, I forgot about this. Let's merge.

@traversaro traversaro merged commit f8e2a58 into robotology:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants