Add use of upload-release-asset GitHub Action #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Via this GitHub Action, it is possible to automatically upload the archive that contains the generate vcpkg archive. See actions/upload-release-asset#34 for details. See iit-danieli-joint-lab/idjl-software-dependencies-vcpkg#7 for a similar PR.
pattacini
approved these changes
Mar 21, 2020
traversaro
added a commit
that referenced
this pull request
Mar 24, 2020
The GitHub Action to upload release assets added in #9 to automatically upload archive in releases was working correctly on small test releases, but it was failing with the error: ~~~ ##[error]Bad credentials ~~~ on the actual release workflow, that was taking more then 4 hours to complete (see for example: https://github.com/iit-danieli-joint-lab/idjl-software-dependencies-vcpkg/runs/529920938?check_suite_focus=true). It turns out that the problem here is that the automatically generated `GITHUB_TOKEN` secret expires after 1 hour: > The installation access token expires after 60 minutes. GitHub fetches a token for each job, before the job begins. > > Note: When a workflow run or its jobs are queued for more than one hour, the token may expire before the job starts. See https://help.github.com/en/actions/configuring-and-managing-workflows/authenticating-with-the-github_token#about-the-github_token-secret . For this reason, despite the examples provided in https://github.com/actions/upload-release-asset use `GITHUB_TOKEN`, for long jobs it make sense to use a proper generated token (see https://help.github.com/en/enterprise/2.17/user/github/authenticating-to-github/creating-a-personal-access-token-for-the-command-line). In this case, I already added a new personal token with the proper permissions in the [secrets](https://help.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets) of this repo under the name `ACCESS_TOKEN`, and this PR makes use of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Via this GitHub Action, it is possible to automatically upload the archive that contains the generate vcpkg archive.
See actions/upload-release-asset#34 for details.
See iit-danieli-joint-lab/idjl-software-dependencies-vcpkg#7 for a similar PR.