-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qt problems with latest Qt from vcpkg #134
Comments
I guess they recompiled everything a was still not working. Am I right? |
If you are using the vcpkg toolchain, did you disable |
Yes, I compiled again all robotology-superbuild from scratch. The iCub Gui works if I run it from Visual Studio, but not if I launch it from command line. |
No, I am not using the vcpkg toolchain. |
Something changed: the executables in the build directory were working correct, but the installed were not working properly: in particular after the line
I am trying to reproduce it on a second setup to be sure about it.
The documented procedure to use |
I reproduced the issue experienced by @InesSorrentino (and by @claudia-lat , even if it was not reported here) with vcpkg commit microsoft/vcpkg@8dc8d0e . To make sure that it was actually a vcpkg issue, I tried also to download the latest Qt 5.11.2 binaries from https://www.qt.io/ , and with those everything (yarpmanager with icons, yarpview) is working fine, so the issue seems to be related to vcpkg indeed. In particular, the issue seems to be related to the Qt Resource System. |
Another test that it may be worth doing would be to compile YARP using the vcpkg's toolchain, instead of manually setting the enviroment variables. I do not expect the result to change, but it may be worth doing this as an additional check. |
I'll try to do it in the next days. |
@claudiofantacci any news by chance on the above test? |
Sorry guys, I froze my |
Given robotology#134 , I think it make sense to do this, at least until robotology#134 is fixed.
I upgraded
|
As mentioned in #134 (comment) , I suspect the issue is related to something that is not working in the Qt Resource System. |
I was able to fix everything, yet again, by adding the following [Paths]
Prefix = C:/Users/cfantacci/vcpkg/installed/x64-windows
Documentation = share/qt5/doc
Headers = include
Libraries = lib
Binaries = tools/qt5
LibraryExecutables = tools/qt5
Plugins = plugins
Qml2Imports = qml
Data = share/qt5
ArchData = share/qt5
HostData = share/qt5
HostBinaries = tools/qt5 Now everything works as expected. Unfortunately, I tried to fix this issue on |
I guess the only permanent solution is to have some tests continuously running, either in vcpkg itself or in an external repo: building Qt is extremely slow, but perhaps with the new Azure CI system it should be doable. Related vcpkg issue: microsoft/vcpkg#72, in particular microsoft/vcpkg#72 (comment) for the "external" test solution. |
The problem is that this scenario si very difficult to test, especially if it involves GUIs. You may have a program silently failing, or just not showing up the icons and you would notice that (unless I'm missing something test-wise). This is clearly an issue that must come from users, and possiby a patch from users themselves. I don't find a way out other than discussing with |
Are you sure? If it is just a qrc problem, we just need to write a test that tries to access a resource using qrc, and fails if it is not able to find it. |
You are right. I was focusing my thoughts on the GUI, and not on the Qt Resource System. 👍 Apart from this, are we going to try discussing with |
If you have a clear understanding of what the issue is (apart from the fact that |
I think I found the problem! Let me double check it and report it here. |
If you open the
Now, by my understanding, every paths that is used by
for the directory
for the directory
and finally for the directory
Looking back at our list, the following paths are wrong:
This paths are overridden by |
I agree. |
I think we can finally close this issue as the PR microsoft/vcpkg#5456 in |
I would prefer if someone successfully tested a complete |
Yes, also there has been another PR that corrected the tools locations and hopefully did not regress to the other full path issue in the Qt5Core. I really fear that we are at an empasse with Qt under |
Possibly this could be a related issue: microsoft/vcpkg#7461 . |
@pattacini you recently updated vcpkg, did you experienced any problem such as the one described in this issue? |
@traversaro yes the latest qt makes our GUI quite screwed up as in the screenshot below, where SVG icons are not rendered properly: |
|
@traversaro that's correct; |
@traversaro I can confirm that the latest Qt version |
For reference: @pattacini in his tests only tested executable in the build directory of YARP, without installing them. |
This has been tested by several people, so we can finally close it and return to document the use of vcpkg for dependencies. |
@InesSorrentino experienced several problems related to running the installed version of
YARP
andICUB
GUIs that use QMLs when using the latest version of Qt installed viavcpkg
.For some reason, the version of the executable contained in the
build
directory seem to be working fine. As there were recently some big changes in how Qt is installed by vcpkg (microsoft/vcpkg#4164 and microsoft/vcpkg#4629), it would be worth to check it this problems are actually reproducible.The text was updated successfully, but these errors were encountered: