IDYNTREE_USES_IRRLICHT is not properly set in Windows even if irrlicht and glfw3 are present in the system

[S-Dafarra]

During a recent demo we noticed that when recompiling the superbuild on a Windows machine, the IDYNTREE_USES_IRRLICHT was getting disabled even if irrlicht and glfw3 are properly found in the system.

I tried to replicate it in my system and I noticed the same.

A perfect occasion to use the CMake debugging functionality of Visual Studio.

I blocked the execution at this line

robotology-superbuild/cmake/BuildiDynTree.cmake

Line 29 in 93504fb

ycm_ep_helper(iDynTree TYPE GIT

Here I noted that the GLFW3_FOUND variable is set to true

On the other nad, inside the ycm_ep_helper function, in the arguments list, I see that -DIDYNTREE_USES_IRRLICHT is empty, i.e.

-DIDYNTREE_USES_IRRLICHT:BOOL=

while for example -DIDYNTREE_USES_PYTHON:BOOL=True

I believe that the problem is the case. In Windows, the variable is all capital, i.e. GLFW3_FOUND, while we check the content of glfw3_FOUND.

I think that the problem can be fixed by using

find_package(GLFW3 QUIET)

instead

[S-Dafarra]

Related PR: #1598

[traversaro]

Fixed by #1599 .