Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use find_package(glfw3) to detect if irrlicht+sdl is available #1599

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

traversaro
Copy link
Member

Solution for #1597, alternative to #1598 . The main problem of #1598 is that it would raise a deprecation warning after robotology/ycm-cmake-modules#441 is merged. Instead, we can already avoid to use the FindGLFW3 script by passing NO_MODULE to find_package(glfw3).

@traversaro traversaro requested a review from S-Dafarra February 13, 2024 19:05
@traversaro
Copy link
Member Author

Cool, somehow find_package(GLFW3) failed on vcpkg, but find_package(glfw3 NO_MODULE) works fine and find glfw3, meaning that it is not a good way to detect if use or not irrlicht. Probably for the sake of the workaround, we can just enable irrlicht if conda is used.

@traversaro traversaro changed the title Pass NO_MODULE to find_package(glfw3) call to avoid any interference with FindGLFW3 module installed by YCM Do not use find_package(glfw3) to detect if irrlicht+sdl is available Feb 13, 2024
@traversaro
Copy link
Member Author

Cool, somehow find_package(GLFW3) failed on vcpkg, but find_package(glfw3 NO_MODULE) works fine and find glfw3, meaning that it is not a good way to detect if use or not irrlicht. Probably for the sake of the workaround, we can just enable irrlicht if conda is used.

Ok, I changed once again the logic, as now I do not use find_package(glfw3) at all.

@traversaro traversaro merged commit b49ea68 into master Feb 14, 2024
37 checks passed
@traversaro traversaro deleted the traversaro-patch-8 branch February 14, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants