Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pin of graphviz to 8 and disable yarpviz compilation on conda until YARP 3.10.0 is released #1603

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

traversaro
Copy link
Member

The pin was added in #1538 as a workaround for #1537, as the proper fixes have been released, we should be able to just drop the pin and use graphviz 9, to avoid incompatibility with libraries that actually use graphviz 9.

@traversaro
Copy link
Member Author

Fix #1602 .

@traversaro
Copy link
Member Author

the proper fixes have been released

This is not true. robotology/yarp#3056 was merged, but was never released, and yarp-3.9 branch and yarp 3.9.0 tag still do not compile with graphviz 9. As graphviz is just used for yarpviz compilation, and as I think that ROS compatibility (see #1602) is more important, I think we can change the workaround to actually disable yarpviz on conda, and re-enable it once YARP 3.10 is released.

@traversaro
Copy link
Member Author

traversaro commented Feb 22, 2024

Indeed, the build still fails, let's disable yarpviz compilation on conda instead.

[20/1300] Building CXX object extern/qgv/CMakeFiles/YARP_priv_qgvcore.dir/qgv/QGVCore/QGVScene.cpp.o
FAILED: extern/qgv/CMakeFiles/YARP_priv_qgvcore.dir/qgv/QGVCore/QGVScene.cpp.o 
/home/runner/miniconda3/envs/test/bin/x86_64-conda-linux-gnu-c++ -DBUILDING_YARP -DQGVCORE_LIB -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_WIDGETS_LIB -I/home/runner/work/robotology-superbuild/robotology-superbuild/b/src/YARP/extern/qgv/YARP_priv_qgvcore_autogen/include -I/home/runner/miniconda3/envs/test/include/eigen3 -I/home/runner/work/robotology-superbuild/robotology-superbuild/src/YARP/extern/qgv/qgv/QGVCore -I/home/runner/work/robotology-superbuild/robotology-superbuild/src/YARP/extern/qgv/qgv/QGVCore/private -I/home/runner/work/robotology-superbuild/robotology-superbuild/b/src/YARP/extern/qgv -I/home/runner/miniconda3/envs/test/include/graphviz -isystem /home/runner/miniconda3/envs/test/include/qt -isystem /home/runner/miniconda3/envs/test/include/qt/QtWidgets -isystem /home/runner/miniconda3/envs/test/include/qt/QtGui -isystem /home/runner/miniconda3/envs/test/include/qt/QtCore -isystem /home/runner/miniconda3/envs/test/./mkspecs/linux-g++ -w -fvisibility-inlines-hidden -fmessage-length=0 -march=no
In file included from /home/runner/work/robotology-superbuild/robotology-superbuild/src/YARP/extern/qgv/qgv/QGVCore/QGVScene.cpp:27:
/home/runner/work/robotology-superbuild/robotology-superbuild/src/YARP/extern/qgv/qgv/QGVCore/private/QGVCore.h: In static member function 'static Agraph_t* QGVCore::agmemread2(const char*)':
/home/runner/work/robotology-superbuild/robotology-superbuild/src/YARP/extern/qgv/qgv/QGVCore/private/QGVCore.h:96:14: error: 'Agdisc_t' {aka 'struct Agdisc_s'} has no member named 'mem'
   96 |         disc.mem = &AgMemDisc;
      |              ^~~
/home/runner/work/robotology-superbuild/robotology-superbuild/src/YARP/extern/qgv/qgv/QGVCore/private/QGVCore.h:96:21: error: 'AgMemDisc' was not declared in this scope; did you mean 'AgIoDisc'?
   96 |         disc.mem = &AgMemDisc;
      |                     ^~~~~~~~~
      |                     AgIoDisc

@traversaro traversaro changed the title Remove pin of graphviz to 8 Remove pin of graphviz to 8 and disable yarpviz compilation on conda until YARP 3.10.0 is released Feb 22, 2024
@traversaro
Copy link
Member Author

let's disable yarpviz compilation on conda instead.

Done in 03f7933 .

@traversaro traversaro merged commit 5ea9a27 into master Feb 22, 2024
27 of 37 checks passed
@traversaro traversaro deleted the removegraphvizworkaround2 branch February 22, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant