Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch expat, xcb and xorg libraries from cdt to proper packages and add xorg-libxrandr package for glfw 3.4 #1606

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Feb 26, 2024

Fix issue similar to robotology/idyntree#1156 but for the superbuild. As a cleanup, I also migrated as much as cdt as possible to regular packages.

@traversaro
Copy link
Member Author

Regular CI is fine. generate-conda-packages is failing with:

2024-02-26T15:48:59.4454392Z [12/36] Building CXX object src/devices/openxrheadset/CMakeFiles/yarp_openxrheadset.dir/yarp_plugin_openxrheadset.cpp.o
2024-02-26T15:48:59.4455381Z FAILED: src/devices/openxrheadset/CMakeFiles/yarp_openxrheadset.dir/yarp_plugin_openxrheadset.cpp.o 
2024-02-26T15:48:59.4461855Z $BUILD_PREFIX/bin/x86_64-conda-linux-gnu-c++ -DGLFont_DEFAULT_FONTS_PATH=\"$SRC_DIR/build/_deps/glfont-src/fonts\" -Dyarp_openxrheadset_EXPORTS -I$SRC_DIR/build/src/devices/openxrheadset -I$SRC_DIR/src/devices/openxrheadset -I$SRC_DIR/src/devices/openxrheadset/rendering -I$SRC_DIR/build/src/devices/openxrheadset/Autogenerated -I$SRC_DIR/build/_deps/glfont-src/include -I$SRC_DIR/src/vendor/stb -isystem $PREFIX/include/eigen3 -isystem $PREFIX/include/freetype2 -fvisibility-inlines-hidden -fmessage-length=0 -march=nocona -mtune=haswell -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O2 -ffunction-sections -pipe -isystem $PREFIX/include -fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/yarp-device-openxrheadset-0.0.3 -fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix -O3 -DNDEBUG -std=c++20 -fPIC -MD -MT src/devices/openxrheadset/CMakeFiles/yarp_openxrheadset.dir/yarp_plugin_openxrheadset.cpp.o -MF src/devices/openxrheadset/CMakeFiles/yarp_openxrheadset.dir/yarp_plugin_openxrheadset.cpp.o.d -o src/devices/openxrheadset/CMakeFiles/yarp_openxrheadset.dir/yarp_plugin_openxrheadset.cpp.o -c $SRC_DIR/build/src/devices/openxrheadset/yarp_plugin_openxrheadset.cpp
2024-02-26T15:48:59.4467710Z In file included from $SRC_DIR/src/devices/openxrheadset/OpenGLConfig.h:38,
2024-02-26T15:48:59.4468346Z                  from $SRC_DIR/src/devices/openxrheadset/ImagePortToQuadLayer.h:12,
2024-02-26T15:48:59.4468916Z                  from $SRC_DIR/src/devices/openxrheadset/OpenXrHeadset.h:28,
2024-02-26T15:48:59.4469553Z                  from $SRC_DIR/build/src/devices/openxrheadset/yarp_plugin_openxrheadset.cpp:10:
2024-02-26T15:48:59.4470485Z $PREFIX/include/GLFW/glfw3native.h:119:12: fatal error: X11/extensions/Xrandr.h: No such file or directory
2024-02-26T15:48:59.4471181Z   119 |   #include <X11/extensions/Xrandr.h>
2024-02-26T15:48:59.4471526Z       |            ^~~~~~~~~~~~~~~~~~~~~~~~~

We need to add the xorg-libxrandr dependencies also in conda.

@traversaro
Copy link
Member Author

New conda metapackage failure:

2024-02-26T20:31:57.8127074Z The reported errors are:
2024-02-26T20:31:57.8127404Z - Encountered problems while solving:
2024-02-26T20:31:57.8128233Z -   - package idyntree-matlab-bindings-10.3.0-ha2d195d_117 requires libxcb >=1.16,<1.17.0a0, but none of the providers can be installed
2024-02-26T20:31:57.8128947Z - 
2024-02-26T20:31:57.8129061Z 

Apparently there is a long never-ended migration to libxcb 1.15. Probably we can just add a local pin to 1.15 for it.

@traversaro
Copy link
Member Author

generate-conda-packages job is also happy: https://github.com/robotology/robotology-superbuild/actions/runs/8057061550 .

@traversaro traversaro merged commit 567f97f into master Feb 27, 2024
42 checks passed
@traversaro traversaro deleted the fixglfw34 branch February 27, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant