Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ROBOTOLOGY_USES_GZ_SIM with apt dependencies on Ubuntu 24.04 #1651

Merged
merged 1 commit into from
May 15, 2024
Merged

Enable ROBOTOLOGY_USES_GZ_SIM with apt dependencies on Ubuntu 24.04 #1651

merged 1 commit into from
May 15, 2024

Conversation

traversaro
Copy link
Member

@traversaro traversaro requested review from Nicogene and xela-95 May 14, 2024 21:30
xela-95
xela-95 approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@xela-95 xela-95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Should we add (here for the superbuild or in the gz-sim-yarp-plugins repo) a runner of the CI having ubuntu 24.04?

@traversaro
Copy link
Member Author

Should we add (here for the superbuild or in the gz-sim-yarp-plugins repo) a runner of the CI having ubuntu 24.04?

Yes, this was done in #1642 , the change in https://github.com/robotology/robotology-superbuild/pull/1651/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fL264 ensures that ROBOTOLOGY_USES_GZ option is indeed enabled in the CI on apt on 24.04 .

@traversaro traversaro merged commit c07d0c7 into master May 15, 2024
25 checks passed
@traversaro traversaro deleted the enablegzsim2404 branch May 15, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xela-95 xela-95 xela-95 approved these changes

@Nicogene Nicogene Awaiting requested review from Nicogene

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@traversaro @xela-95