Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump YCM bootstrapped version to latest released version v0.10.4 #224

Merged
merged 1 commit into from
Jul 4, 2019

Conversation

traversaro
Copy link
Member

Without this change, YARP downloads its own version of YCM, as 0.10.2 is not recent enough for YARP.

Without this change, YARP downloads its own version of YCM, as 0.10.2 is not recent enough for YARP.
@traversaro traversaro requested a review from xEnVrE July 1, 2019 10:12
@traversaro
Copy link
Member Author

Eventually we can just track the latest master of YCM as we do for most robotology dependencies, but historically we used fixed release for YCM as the boostrap process is quite delicate.

Copy link
Member

@diegoferigo diegoferigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are no strong opinions against using a specific version of YCM, I would just switch to master in order to simplify maintenance

Copy link
Collaborator

@claudiofantacci claudiofantacci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄
Just my two cents here: for the specific use of YCM, I find convenient to specify a release version, rather than master, as I am able to easily track down specific YCM features that I require for a project.

@traversaro
Copy link
Member Author

If there are no strong opinions against using a specific version of YCM, I would just switch to master in order to simplify maintenance

That's indeed what we always did with the rest of robotology-software. At some point in time I stopped tracking master for YCM because the bootstrap mechanism is quite delicate and tended to break quite frequently. I think we can now switch to master again, but let's think a bit about it.

@traversaro
Copy link
Member Author

Test failures are unrelated (actually due to robotology/gazebo-yarp-plugins#433), merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants