-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gym-ignition project #685
Conversation
be967f7
to
8a0e3c3
Compare
886009d
to
85d1ea3
Compare
|
85d1ea3
to
6a3e8b6
Compare
|
cmake/Buildgym-ignition.cmake
Outdated
CMAKE_ARGS -DSCENARIO_USE_IGNITION:BOOL=${ROBOTOLOGY_USES_IGNITION} | ||
-DSCENARIO_ENABLE_BINDINGS:BOOL=${ROBOTOLOGY_USES_PYTHON} | ||
-DBINDINGS_INSTALL_PREFIX:PATH=${ROBOTOLOGY_SUPERBUILD_PYTHON_INSTALL_DIR} | ||
DEPENDS iDynTree ign-gazebo5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@traversaro is the ign-gazeboX
dependency OK? (There's a typo and this should be 4 for the current master
, but I'm not sure that adding it is necessary)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I typically set DEPENDS
only to the value of other projects that are handled by the superbuild. I am not really sure how it works for projects not handled by the superbuild, so if it works I would just leave iDynTree there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doc/profiles.md
Outdated
Follow the official instructions to install Ignition on your platform, available at https://ignitionrobotics.org/docs. | ||
|
||
Different Ignition distributions can be installed alongside. | ||
The projects included in the superbuild might require different distributions. | ||
From the superbuild point of view, we currently do not allow enabling projects that only support a specific Ignition distribution, therefore all required distributions have to be found in the system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we support only Conda/Linux for ROBOTOLOGY_USES_IGNITION
, we should describe here how to install Ignition Gazebo on conda (preferably the version tested in CI), as the official docs of Ignition Gazebo do not cover that the installation in conda.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b76fbfe
to
640c577
Compare
640c577
to
74ffd01
Compare
CI failures don't seem related to this PR. CI failure message
|
Are you sure? All other CI builds are working fine. Are you sure that it is not due to the |
74ffd01
to
3c8d523
Compare
Checking the logs you're right, not sure why my local setup just configures it. I tried it locally before committing (and thinking about it, it's not the first time I notice this behavior) 🤷♂️ |
It seems good to go now, thanks (even if I would like to solve conda-forge/libignition-gazebo-feedstock#4 before advertising it). |
robotology/gym-ignition
to thecore
profileROBOTOLOGY_USES_IGNITION
option to enable code that depends on Ignition librariesRemarks:
gym-ignition
to thecore
profile since on the long term we could have something similar togazebo-yarp-plugins
for Ignition Gazebo, and Ignition support will likely be part ofcore
gym-ignition
depends onidyntree
, therefore ifROBOTOLOGY_USES_IGNITION=ON
andROBOTOLOGY_ENABLE_DYNAMICS=OFF
, alsoidyntree
and all its dependent projects will be installedROBOTOLOGY_USES_IGNITION
only in condaTODOs:
robotology-superbuild/cmake/Buildgym-ignition.cmake
Line 21 in 85d1ea3