Ad nlohmann-json as dependency of the superbuild #776
Conversation
This was fixed by de82b26 . As the vcpkg tarball has shown to be more stable lately, I switched CI to also use latest as originally suggested by @S-Dafarra, for consistency with the user docs. |
| @@ -406,6 +413,11 @@ jobs: | |||
| cd build | |||
| cmake -DROBOTOLOGY_ENABLE_DYNAMICS_FULL_DEPS:BOOL=OFF . | |||
|
|
|||
| - name: Install dependencies unsupported in Ubuntu 18.04 | |||
| if: contains(matrix.os, '20.04') | |||
There was a problem hiding this comment.
Why the condition is different here?
There was a problem hiding this comment.
Because it is for installing dependencies that are not available on 18.04, so it is run on Ubuntu 20.04 .
There was a problem hiding this comment.
Sorry, I should have been more precise. I meant with respect to the similar if clause above at line 231
There was a problem hiding this comment.
I saw later that one applies to docker images and this to os. Not important at all
There was a problem hiding this comment.
I saw later that one applies to docker images and this to os. Not important at all
Yes, that's it. The clause are different as for the docker images you need to check the used docker image, not the base os.
|
The Conda/Linux CI failure are unrelated (see #785), I think once the other jobs finish we can merge. |
Fix #763 . I added it as a dependency in all points, I am just missing robotology/robotology-superbuild-dependencies-vcpkg#45 to also bump the version of vcpkg dependencies used in CI.