-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document required apt dependencies in machine readable format with apt.txt file #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S-Dafarra
reviewed
Jul 14, 2021
Co-authored-by: Stefano Dafarra <stefano.dafarra@gmail.com>
S-Dafarra
approved these changes
Jul 14, 2021
Nicogene
approved these changes
Jul 14, 2021
fyi @pattacini |
Nice feature! |
Nicogene
pushed a commit
to Nicogene/robotology-superbuild
that referenced
this pull request
Feb 14, 2022
…t.txt file (robotology#825) Co-authored-by: Stefano Dafarra <stefano.dafarra@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A trend that we noticed in the latest years was that the long list of apt dependencies of the superbuild tended to be duplicated in many places (Docker image recipes, documentation pages on how to install the superbuild). This clearly created problem anytime the list of dependencies changed, as all the hardcoded copies of the list were outdated and needed to be manually updated.
To solve this problem, this PR does the following:
apt.txt
file in the root of the repo (convention copied by repo2docker, see https://repo2docker.readthedocs.io/en/latest/config_files.html#apt-txt-install-packages-with-apt-get). The rest of dependencies that are required only for specific options are instead still documented manually, but I noticed that in practice those dependencies are much less used.sudo bash ./scripts/install_apt_dependencies.sh
script to install the dependencies, that just install via apt-get all the dependncies listed in the apt.txt file.This change will be released first in Distro Release 2021.08, so unfortunatly it will be possible to use it only from that point on.