-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tune the low level gains of the iCubGazeboV3 #106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Actually, I think that we can target directly |
Nice! At this point isnt better to commits those gains directly in icub models? |
Ok, if you think it is better to commit there then sure. The guys from HSP were installing everything individually and not through the superbuild, so that makes sense. |
Let me know if this PR is corresponding to what you suggested. In which case we can merge/close this one perhaps. |
Hi @mebbaid did you open a PR in icub-models-generator as suggested by @traversaro in robotology/icub-models#126? Can I close this PR? |
The suggested PR is not opened yet. The halt is due to me not being able to verify the same good behaviour in a different machine used by the HSP team. So I am spending sometime tuning and was going to close once the other PR is opened. |
Opened a corresponding PR in Closing
|
after yesterdays issues during the meeting, now with a clean build, using master or devel, and with those pidparams, it seems the simulation is more reproducible and stable than before (see attached video)
working_tuned_pid.MP4
.