Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] QpOases: Switch to use reliable options #208

Closed
wants to merge 1 commit into from

Conversation

traversaro
Copy link
Member

Fix #202 . As per @lrapetti tests, on typical QP instances used in robotic Whole-Body Control the time difference is not big, and using the reliably settings seems safer.

@traversaro traversaro requested a review from diegoferigo as a code owner May 18, 2021 09:12
@traversaro
Copy link
Member Author

cc @CarlottaSartore It could be worth to give it a shot to this PR.

@lrapetti
Copy link
Member

As I was mentioning in #202 (comment), I have observed some unexpected behaviour. I would try to run again this option before merging (I will switch to this branch today).

@traversaro
Copy link
Member Author

As I was mentioning in #202 (comment), I have observed some unexpected behaviour. I would try to run again this option before merging (I will switch to this branch today).

Ah cool, I have missed that.

@CarlottaSartore
Copy link
Contributor

In my environment the change to reliable causes the QP to fail I would say always

@traversaro traversaro changed the title QpOases: Switch to use reliable options [WIP] QpOases: Switch to use reliable options May 18, 2021
@traversaro
Copy link
Member Author

As this seems to have a serious impact in some applications, and in any case a replacement block is being provided in #209 , I would close this.

@traversaro traversaro closed this May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set/expose qpOASES's setToReliable option?
4 participants