Remove deprecated and not used iDynTree headers #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WBBlock.cpp included some headers of iDynTree that will be deprecated in iDynTree 2, and in general are not actually used. They were probably inserted by IWYU, but it is possible to compile fine without including them even with iDynTree 1.
|
Thanks @traversaro, if I recall these were iwyu suggestions. Removing them is harmless. |
diegoferigo
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WBBlock.cpp included some headers of iDynTree that will be deprecated in iDynTree 2, and in
general are not actually usedactually they are used, but for compatibility with future iDynTree it is better not too IWYU in this case, as it is possible to compile fine without including them even with iDynTree 1.This should avoid problems like robotology/robotology-superbuild#422 in the future.