-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conda-based Continuous Integration job #212
Conversation
The conda-based CI script seems to be working fine. As it seems easier to maintain that the apt/brew/vcpkg one, I would simply delete the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The conda-based CI script seems to be working fine. As it seems easier to maintain that the apt/brew/vcpkg one, I would simply delete the
ci.yml
job and just use theconda-ci.yml
, what do you think @diegoferigo ? Compilation via apt will be checked in any case daily via the https://github.com/robotology/robotology-superbuild .
I completely agree on using conda! We can then create a new workflow for just the website (or extend this one) as soon as #207 is fixed.
.github/workflows/conda-ci.yml
Outdated
- name: Dependencies | ||
shell: bash -l {0} | ||
run: | | ||
# Compilation related dependencies | ||
mamba install cmake compilers ninja pkg-config | ||
# Actual dependencies | ||
mamba install eigen blockfactory idyntree osqp-eigen qpoases yarp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy-and-paste duplication?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
- name: Test | ||
shell: bash -l {0} | ||
run: | | ||
cd build | ||
ctest --output-on-failure -C ${{ matrix.build_type }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we have tests here, maybe we can leave these lines commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line works fine also for repo that do not have tests, and will automatically start to run tests if tests are added. Given that I plan to wrap this logic in a github action to avoid duplicate code, and I would keep this for consistency with the rest of other repos.
I think the workflow for the website is already there: https://github.com/robotology/wb-toolbox/blob/add-conda-ci/.github/workflows/website.yml ? |
This PR adds a conda-based CI workflow for Windows, macOS and Linux, simpler then the already present (and currently broken) CI jobs.