Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conda-based Continuous Integration job #212

Merged
merged 5 commits into from
May 19, 2021
Merged

Add conda-based Continuous Integration job #212

merged 5 commits into from
May 19, 2021

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented May 19, 2021

This PR adds a conda-based CI workflow for Windows, macOS and Linux, simpler then the already present (and currently broken) CI jobs.

@traversaro
Copy link
Member Author

traversaro commented May 19, 2021

The conda-based CI script seems to be working fine. As it seems easier to maintain that the apt/brew/vcpkg one, I would simply delete the ci.yml job and just use the conda-ci.yml, what do you think @diegoferigo ? Compilation via apt will be checked in any case daily via the https://github.com/robotology/robotology-superbuild .

Copy link
Member

@diegoferigo diegoferigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conda-based CI script seems to be working fine. As it seems easier to maintain that the apt/brew/vcpkg one, I would simply delete the ci.yml job and just use the conda-ci.yml, what do you think @diegoferigo ? Compilation via apt will be checked in any case daily via the https://github.com/robotology/robotology-superbuild .

I completely agree on using conda! We can then create a new workflow for just the website (or extend this one) as soon as #207 is fixed.

Comment on lines +38 to +44
- name: Dependencies
shell: bash -l {0}
run: |
# Compilation related dependencies
mamba install cmake compilers ninja pkg-config
# Actual dependencies
mamba install eigen blockfactory idyntree osqp-eigen qpoases yarp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy-and-paste duplication?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Comment on lines +68 to +72
- name: Test
shell: bash -l {0}
run: |
cd build
ctest --output-on-failure -C ${{ matrix.build_type }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have tests here, maybe we can leave these lines commented out?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line works fine also for repo that do not have tests, and will automatically start to run tests if tests are added. Given that I plan to wrap this logic in a github action to avoid duplicate code, and I would keep this for consistency with the rest of other repos.

@traversaro
Copy link
Member Author

The conda-based CI script seems to be working fine. As it seems easier to maintain that the apt/brew/vcpkg one, I would simply delete the ci.yml job and just use the conda-ci.yml, what do you think @diegoferigo ? Compilation via apt will be checked in any case daily via the https://github.com/robotology/robotology-superbuild .

I completely agree on using conda! We can then create a new workflow for just the website (or extend this one) as soon as #207 is fixed.

I think the workflow for the website is already there: https://github.com/robotology/wb-toolbox/blob/add-conda-ci/.github/workflows/website.yml ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants