Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with YARP 3.10 #206

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Fix compatibility with YARP 3.10 #206

merged 4 commits into from
Feb 29, 2024

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Feb 29, 2024

  • serialComPortName is unused, so we remove it
  • attachedWearableDeviceName is actually used for some print information, but it is not particular useful to print the device, as if you have multiple devices (for example, a left and right couple of device) both they will have the same device value. Instead, it is more useful to print the key that have been passed to the attachAll method, that is the name attribute of the elem tag child of the in the attach-related element of the yarprobotinterface xml, see for example
    <elem name="HapticGloveWearableDeviceActuatorWrapperLabel"> RightHapticGloveWearableDevice </elem>
    .

Fix #205 .

@traversaro traversaro requested a review from S-Dafarra February 29, 2024 15:19
@traversaro traversaro closed this Feb 29, 2024
@traversaro traversaro reopened this Feb 29, 2024
@traversaro
Copy link
Member Author

fyi @mebbaid @GiulioRomualdi

@traversaro traversaro merged commit a485998 into master Feb 29, 2024
6 checks passed
EhsanRanjbari pushed a commit to EhsanRanjbari/wearables that referenced this pull request May 16, 2024
* Fix compatibility with YARP 3.10
@traversaro traversaro deleted the fixyarp310 branch September 23, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation failure with yarp 3.10
2 participants