Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream T256 tracking camera pose using analogServer device #18

Merged
merged 4 commits into from
May 28, 2021

Conversation

HosameldinMohamed
Copy link
Contributor

Details in #7.

With this PR:

You can also publish RealSense T256 pose using the analogServer device. Run it using:

yarpdev --device analogServer --name /t265 --period 10 --subdevice realsense2Tracking

💡 NOTE: also here, the user should specify the parameters --name and --period as needed.

The command will open a port /t256 that streams the pose as follows:

<positionX positionY positionZ QuaternionW QuaternionX QuaternionY QuaternionZ>

Copy link
Member

@Nicogene Nicogene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you please add a line to the CHANGELOG.md? Thanks!

@HosameldinMohamed
Copy link
Contributor Author

LGTM, could you please add a line to the CHANGELOG.md? Thanks!

@Nicogene I rebased on master then updated the CHANGELOG file.

@traversaro traversaro merged commit 250f8d8 into robotology:master May 28, 2021
@traversaro
Copy link
Member

Thanks @HosameldinMohamed @Nicogene !

@HosameldinMohamed HosameldinMohamed deleted the streamSignalPort branch May 28, 2021 13:45
@randaz81
Copy link
Member

I have to say that using a super generic interface such as AnalogSensor to stream out quaternions sounds very dirty to me.

The elements of the vector of that interface are expected to be independent analog channels. But the four elements of a quaternion are not independent. Additionally: analogServer is marked for deprecation in the very near future!! Additionally2: there exists an ad-hoc yarp::math::Quaternion class.

Can't you use a better interface?

@HosameldinMohamed
Copy link
Contributor Author

I have to say that using a super generic interface such as AnalogSensor to stream out quaternions sounds very dirty to me.

The elements of the vector of that interface are expected to be independent analog channels. But the four elements of a quaternion are not independent. Additionally: analogServer is marked for deprecation in the very near future!!

I was actually looking for a quick way to stream the pose in Simulink using wb-toolbox. This was the quickest way I could do it. But I agree it wasn't what analogServer is made for.

Can't you use a better interface?

mmmmm I don't know a better solution that involves an interface. Do you suggest another way to be able to stream the pose in Simulink?

Additionally2: there exists an ad-hoc yarp::math::Quaternion class.

I'll look into this.

@traversaro
Copy link
Member

Hi @HosameldinMohamed @randaz81, I added a few pointers related to this issue in #7 (comment) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants