Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake 3.12 still has some minor issues with the current
master
. The reason is thatUseSwig.cmake
has been recently refactored.CMake versions >= 3.8 have new utilities for swig, and it makes sense to start adopting them. However, since we need to support CMake 3.5, the previous logic cannot be entirely removed.
This PR contains the following changes:
FindMatlab.cmake
(CMake >= 3.5 is more than enough)yarp.i
from the install directory (See Clone order of yarp and yarp-matlab-bindings affects the binding generation #18)For the time being I tested only generating the bindings and compiling them with octave. I used CMake 3.12.0 and CMake 3.10.2.
TODO
.i
files from yarpcc @traversaro @nunoguedelha