-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yarp rfmodule plugin #1532
Yarp rfmodule plugin #1532
Conversation
39f7089
to
1e34b61
Compare
i don't know why, but for some reasons the pr is not aligned with the branch on my remote. In particular a file was renamed from i suspect the problem to be related to the warning on [https://help.github.com/articles/about-pull-requests/](this page) wich says the fact is that i didn't push on the pull request branch (in origin) but on the one on my remote and reading the statement isn't clear on which branch is forbidden the force push. |
be340c9
to
3c2aa04
Compare
e6deab9
to
48c3aeb
Compare
48c3aeb
to
6548ea9
Compare
53118d7
to
c7bd702
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a dummy example that implements an RFModule as plugin?
It would be really useful for reviewing the PR.
c7bd702
to
1282d5e
Compare
@aerydna ping. This PR is in a pretty good shape, but it still needs documentation and examples, do you think you can find some time to take care of that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the changelog.
i'll try to find some time for finishing the pr but i cannot guarantee when i'll do it. it may be postponed to late november for the examples part. other stuff are quick |
358e0b2
to
2097ba2
Compare
392c864
to
8bbefd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8bbefd4
to
9db17c5
Compare
Rebased and updated copyright. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The following pr adds the new type of plugin RFModule.
After including
RFModuleFactory.h
and creating an instance ofRFPlugin
will be possible to load dinamically or statically an RFModule callingRFPlugin::open(string commandline)
.On the other side, to generate an RFModule plugin will be enough to use the usual
yarp_prepare_plugin
andyarp_add_plugin
macroThe purpose is to give the possibility of running existing modules in a single process contest.