MultiplAnalogSensorsClient: add --externalConnection option #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicogene
added
PR Type: Feat/Enh
Nicogene
force-pushed
the
addOptionsMasClient
branch
2 times, most recently
from
649499c to
a31b293
Compare
Nicogene
added
PR Status: Changelog - Not Required
traversaro
reviewed
Sep 24, 2019
src/devices/multipleanalogsensorsclient/MultipleAnalogSensorsClient.h
Outdated
Show resolved
Hide resolved
|
cc @prashanthr05 this may be useful for the use case "run estimator over offline data". |
Nicogene
force-pushed
the
addOptionsMasClient
branch
from
a31b293 to
2af443f
Compare
Nicogene
added a commit
to Nicogene/icub-main
that referenced
this pull request
Sep 24, 2019
Nicogene
changed the title
Nicogene
force-pushed
the
addOptionsMasClient
branch
from
2af443f to
dea5869
Compare
Nicogene
added
PR Status: Test on Hardware - OK
|
I successfully tested this patch with the Ready to be merged. Waiting green light @traversaro |
traversaro
requested changes
Sep 25, 2019
src/devices/multipleanalogsensorsclient/MultipleAnalogSensorsClient.cpp
Outdated
Show resolved
Hide resolved
src/devices/multipleanalogsensorsclient/MultipleAnalogSensorsClient.cpp
Outdated
Show resolved
Hide resolved
Nicogene
force-pushed
the
addOptionsMasClient
branch
from
dea5869 to
db2387a
Compare
traversaro
approved these changes
Sep 25, 2019
Nicogene
added
PR Status: Changelog - OK
Nicogene
added a commit
to Nicogene/icub-main
that referenced
this pull request
Sep 25, 2019
Nicogene
added a commit
to robotology/icub-main
that referenced
this pull request
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TESTED
Please @traversaro check if I am missing something