Skip to content

sig/Image: Fix topIsLow handling in YARP 3.4 #2612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2021

Conversation

drdanz
Copy link
Member

@drdanz drdanz commented Jun 16, 2021

As explained in #2609 and #2587, this patch restores compatibility in the protocol, when an image with topIsLow==false is sent by YARP 3.5.


Libraries

sig

Image

  • Fixed compatibility with images with topIsLow==false sent by YARP 3.5.

GUIs

yarpview

  • Fixed upside down image when topIsLow is false (Qt >= 5.3.2 only).

@drdanz drdanz temporarily deployed to code-analysis June 16, 2021 12:00 Inactive
@drdanz drdanz temporarily deployed to code-analysis June 16, 2021 12:00 Inactive
@drdanz drdanz temporarily deployed to code-analysis June 16, 2021 12:00 Inactive
@sonarqubecloud
Copy link

@Nicogene
Copy link
Member

If it has been tested, LGTM

@drdanz drdanz self-assigned this Jun 16, 2021
@drdanz drdanz merged commit c770039 into robotology:yarp-3.4 Jun 16, 2021
@drdanz drdanz deleted the fix_topIsLow_yarp-3.4 branch June 16, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants