Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audioFromFileDevice bugfix #2663

Merged
merged 2 commits into from
Jul 26, 2021
Merged

Conversation

randaz81
Copy link
Member

fixed module audioFromFileDevice when channels are > 1

@update-docs
Copy link

update-docs bot commented Jul 20, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in doc/release/<target_branch>, based on your changes.

@randaz81 randaz81 force-pushed the audioFromFile_fix branch from 7d7cb73 to 64c7cdc Compare July 20, 2021 16:58
@randaz81 randaz81 requested a review from drdanz as a code owner July 20, 2021 16:58
@randaz81 randaz81 temporarily deployed to code-analysis July 20, 2021 17:00 Inactive
@randaz81 randaz81 temporarily deployed to code-analysis July 20, 2021 17:00 Inactive
@randaz81 randaz81 temporarily deployed to code-analysis July 20, 2021 17:00 Inactive
@randaz81 randaz81 force-pushed the audioFromFile_fix branch from 64c7cdc to 3452700 Compare July 20, 2021 20:31
@randaz81 randaz81 temporarily deployed to code-analysis July 20, 2021 20:33 Inactive
@randaz81 randaz81 temporarily deployed to code-analysis July 20, 2021 20:33 Inactive
Copy link
Member

@drdanz drdanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add the changelog

@randaz81 randaz81 merged commit e58ffbe into robotology:yarp-3.5 Jul 26, 2021
@randaz81 randaz81 deleted the audioFromFile_fix branch July 28, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants