Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audio gain fix #2664

Merged
merged 2 commits into from
Jul 26, 2021
Merged

Audio gain fix #2664

merged 2 commits into from
Jul 26, 2021

Conversation

randaz81
Copy link
Member

fixed parsing of parameters hw_gain and sw_gain in the two classes AudioPlayerDeviceBase and AudioRecorderDeviceBase

@randaz81 randaz81 self-assigned this Jul 26, 2021
@randaz81 randaz81 requested a review from drdanz as a code owner July 26, 2021 09:55
drdanz
drdanz approved these changes Jul 26, 2021
View reviewed changes
Copy link
Member

@drdanz drdanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@randaz81 randaz81 merged commit 0876f08 into robotology:yarp-3.5 Jul 26, 2021
@randaz81 randaz81 deleted the audio_gain branch July 28, 2021 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drdanz drdanz drdanz approved these changes

Assignees

@randaz81 randaz81

Labels
Component: Library - YARP_dev PR Type: Bugfix This PR fixes some bug Target: YARP v3.5.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@randaz81 @drdanz