Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logger lost messages #2767

Closed
wants to merge 1 commit into from
Closed

Fix logger lost messages #2767

wants to merge 1 commit into from

Conversation

randaz81
Copy link
Member

A possible solution for issue #2643, already addressed by PR #2667 , but using a different, not-blocking technique.

The performance of this solution still has to be investigated.

@randaz81 randaz81 requested a review from drdanz as a code owner November 22, 2021 16:08
@randaz81 randaz81 temporarily deployed to code-analysis November 22, 2021 16:10 Inactive
@randaz81 randaz81 temporarily deployed to code-analysis November 22, 2021 16:10 Inactive
@randaz81 randaz81 temporarily deployed to code-analysis November 22, 2021 16:10 Inactive
@drdanz
Copy link
Member

drdanz commented Nov 23, 2021

Unfortunately PortWriterBuffer is used internally in BufferedPort and blocks when there is another message in the queue. Therefore this implementation has the same issue as #2667

@drdanz drdanz marked this pull request as draft December 16, 2021 07:25
@randaz81
Copy link
Member Author

replaced by #2789

@randaz81 randaz81 closed this Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drdanz drdanz Awaiting requested review from drdanz

Assignees

@drdanz drdanz

@randaz81 randaz81

Labels
Component: Library - YARP_os Resolution: Superseeded Target: YARP v3.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@randaz81 @drdanz