Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change build path for yarp tests #2943

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Change build path for yarp tests #2943

merged 1 commit into from
Feb 14, 2023

Conversation

randaz81
Copy link
Member

Tests are no longer placed in /build/tests folder.
Instead, they are now placed into /build folder.
This is required to fix some CI issues, i.e. the tests placed into /build/tests were not able to find some yarp libraries without appending the /build folder to path (in Win32)
Discussed with @traversaro

Instead, they are now placed into /build folder.
@randaz81 randaz81 added the Type: Admin Involves some intervention from a system administrator or some issue in the infrastructure label Feb 14, 2023
@randaz81 randaz81 added this to the YARP 3.8.0 milestone Feb 14, 2023
@randaz81 randaz81 requested a review from traversaro February 14, 2023 11:49
@randaz81 randaz81 self-assigned this Feb 14, 2023
@update-docs
Copy link

update-docs bot commented Feb 14, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in doc/release/<target_branch>, based on your changes.

@randaz81 randaz81 temporarily deployed to code-analysis February 14, 2023 11:52 — with GitHub Actions Inactive
@traversaro
Copy link
Member

To check that everything is working you can remove these lines of the CI code:

# Append output bin directory to the PATH
.

@randaz81 randaz81 merged commit 71d6639 into master Feb 14, 2023
@randaz81 randaz81 deleted the tests-build-path-change branch February 14, 2023 13:18
randaz81 added a commit that referenced this pull request Feb 14, 2023
@randaz81 randaz81 mentioned this pull request Feb 14, 2023
@randaz81
Copy link
Member Author

To check that everything is working you can remove these lines of the CI code:

# Append output bin directory to the PATH

.

addressed by #2944

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Admin Involves some intervention from a system administrator or some issue in the infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants