Merge setAlignment commands in yarpmotorgui
#2963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterBowman
had a problem deploying
to
code-analysis
GitHub Actions
Failure
PeterBowman
had a problem deploying
to
code-analysis
GitHub Actions
Failure
PeterBowman
temporarily deployed
to
code-analysis
GitHub Actions
Inactive
Apparently, CPU usage skyrockets whenever these are split.
PeterBowman
force-pushed
the
yarpmotorgui_cpu
branch
from
a3589ca to
e953dae
Compare
PeterBowman
had a problem deploying
to
code-analysis
GitHub Actions
Failure
PeterBowman
had a problem deploying
to
code-analysis
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2955. Apparently, CPU usage skyrockets when these commands are split, and also the application segfaults on exit. I merged them following the API docs and verified that
Qt::AlignLeftandQt::AlignVCentercope well together (had to check View > View Position Target Value).cc @xEnVrE please give it a try on your end
cc @randaz81 regarding 54c1a6f (#2947).