Add support for long paths on Windows for yarpidl_thrift #3057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in |
traversaro
force-pushed
the
yarpidlthriftsupportwinlongpath
branch
from
f610ec1 to
581c266
Compare
traversaro
had a problem deploying
to
code-analysis
GitHub Actions
Failure
traversaro
temporarily deployed
to
code-analysis
GitHub Actions
Inactive
traversaro
had a problem deploying
to
code-analysis
GitHub Actions
Failure
randaz81
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
yarp_add_idlandyarp_idl_to_dirmacros can be called in deeply nested folders in downstream projects, and theyarpidl_thriftinvoked by them also create really long paths when creating the temporary folders it creates. For this reason, it can happen that the paths on whichyarpidl_thriftoperates violates the 260 maximum character limit on Windows. To use the support for longer paths, as documented in https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation it is necessary to add a specific manifest to the executable.This PR adds support to
yarpidl_thriftto deal with path longer than 260 characters on Windows.