-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed installation of yarp_sig header files #3137
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in |
Quality Gate passedIssues Measures |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
yarp/src/libYARP_sig/src/CMakeLists.txt Line 192 in a53da60
@randaz81 shouldn't we also install private IDL headers, as in YARP_dev? set_property(TARGET YARP_sig PROPERTY PRIVATE_HEADER ${YARP_sig_IMPL_HDRS} ${YARP_sig_idl_IMPL_HDRS}) |
Would it be OK if I open a PR to patch this? It doesn't seem to cause trouble now, but I believe it might explode at some point later, and such tiny things are prone to being hard to debug. Edit: see #3142. |
Added install of header files generated by thtift in yarp_sig