ControlBoardWrapper2 cleanup and small improvment #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 29, 2016 11:37
traversaro
reviewed
Dec 1, 2016
| @@ -31,7 +31,7 @@ class YARP_dev_API yarp::dev::ImplementTorqueControl: public ITorqueControl | |||
| double *temp; | |||
| double *temp2; | |||
| int *temp_int; | |||
| yarp::dev::Pid *fake; | |||
| // yarp::dev::Pid *fake; | |||
There was a problem hiding this comment.
+1 for just delete it, if we ever need this git remembers .
|
Test passed, can I merge this PR? |
|
@barbalberto Did you see the comment in #988 (comment) (not really important, we can merge anyway, but it would be nice to get rid of the useless comment)? |
|
ok, done it. Any other things? |
traversaro
approved these changes
Dec 5, 2016
|
Ok for me! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed unused variable
propagate device name to ControlBoardWrapper2 subdevices to have more meaningful error messages