Fix handling of PRIVATE_DEPENDENCIES in install_basic_package_files #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@drdanz Let me know if you prefer me to create the 0.11.2 or if you prefer something else. |
drdanz
approved these changes
Jun 16, 2020
|
Good catch! I'd say that we can merge it in ycm-0.11, but we can decide later if we should release ycm 0.12 or 0.11.2 |
|
@traversaro Can you please add a line to the release notes? |
Where? I asked about the creation of the 0.11.2 file exactly for adding a line there. |
|
@traversaro I just added the file in the ycm-0.11 branch, can you please rebase and and update add the changelog? Thanks |
|
@traversaro Any news on this PR? |
I had missed your comments, I will update the changelog in the next days, thanks! |
Before the commit the PRIVATE_DEPENDENCIES argument of install_basic_package_files was ignored unless DEPENDENCIES was also set.
traversaro
force-pushed
the
fix-private-deps
branch
from
fad7732
to
463316d
Compare
drdanz
approved these changes
Jul 14, 2020
|
I added the release docs. |
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the commit the PRIVATE_DEPENDENCIES argument of install_basic_package_files was ignored unless DEPENDENCIES was also set.