Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Compatibility with CMake < 3.10 will be removed" warnings in gitsafeclone.txt.in #475

Merged
merged 1 commit into from
Mar 1, 2025

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Mar 1, 2025

CMake started complaining for projects that requested 3.5 as cmake_minimum_required (see https://gitlab.kitware.com/cmake/cmake/-/commit/55778f5a16ffe1b67123a31f6b568f2f7c0a1f36), so it make sense to bump the cmake_minimum_required used in gitsafeclone to 3.16 (as the general one of YCM).

This will fix all the warnings:

CMake Deprecation Warning at /home/runner/work/robotology-superbuild/robotology-superbuild/b/src/OsqpEigen/CMakeFiles/YCMTmp/OsqpEigen-gitsafeclone.cmake:8 (cmake_minimum_required):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

that occur when using a YCM-based superbuild with a recent CMake version.

@traversaro traversaro changed the title Fix warnings in gitsafeclone.txt.in Fix "Compatibility with CMake < 3.10 will be removed" warnings in gitsafeclone.txt.in Mar 1, 2025
@traversaro traversaro merged commit 8cecd5b into master Mar 1, 2025
15 checks passed
@traversaro traversaro deleted the fixdeprecationwarnings branch March 1, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant