Skip to content

Conversation

josephshanak
Copy link
Contributor

This PR updates the plugin to support CakePHP4.

@josephshanak josephshanak mentioned this pull request Oct 15, 2020
@robertpustulka robertpustulka self-assigned this Oct 28, 2020
@robertpustulka
Copy link
Member

robertpustulka commented Oct 28, 2020

Thanks! Please update the travis.yml file to test against PHP 7.2, 7.3 and 7.4

@josephshanak
Copy link
Contributor Author

Thanks! Please update the travis.yml file to test against PHP 7.2, 7.3 and 7.4

Done. I removed 5.6 and 7.1 as the minimum supported version for Cake 4 is PHP 7.2

@codecov
Copy link

codecov bot commented Nov 1, 2020

Codecov Report

Merging #9 into master will increase coverage by 0.52%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #9      +/-   ##
============================================
+ Coverage     95.16%   95.68%   +0.52%     
+ Complexity       52       50       -2     
============================================
  Files             4        4              
  Lines           124      116       -8     
============================================
- Hits            118      111       -7     
+ Misses            6        5       -1     
Impacted Files Coverage Δ Complexity Δ
src/Model/Behavior/StiBehavior.php 98.27% <100.00%> (-0.03%) 26.00 <3.00> (ø)
src/Model/Behavior/StiParentBehavior.php 92.00% <100.00%> (+0.77%) 20.00 <3.00> (-2.00) ⬆️
src/Model/Entity/CopyableEntityTrait.php 100.00% <100.00%> (ø) 1.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbd51c0...9e7208c. Read the comment docs.

@Theaxiom
Copy link

Theaxiom commented Nov 5, 2020

@josephshanak thanks for your contribution!

@robertpustulka May be please get this merged in so we can pull it with composer? Thanks!

@robertpustulka robertpustulka merged commit 3434ea8 into robotusers:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants