add edits for merging defers at the same level #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaacovCR
force-pushed
the
merge
branch
4 times, most recently
from
c92c975
to
0770844
Compare
robrichard
force-pushed
the
incremental
branch
from
c44101c
to
79da712
Compare
yaacovCR
force-pushed
the
merge
branch
2 times, most recently
from
1e8825a
to
b230c5b
Compare
Rather than merging subSelectionSets of a field group using MergeSelectionSets and then calling CollectFields, introducing CollectSubfields allows the field group's groupedSubfieldSet to be calculated directly.
|
closing in favor of graphql#1026 ... as an aside, I opened that PR on the upstream repo, but we could instead merge it into robrichard:incremental, as it is built on top of all the amazingness of graphql#742 |
|
actually i forgot => the main purpose of graphql#1026 at this point is just to facilitate review of the associated implementation stack PR. before it can be merged anywhere, we have to decide if we want the spec to describe concurrent execution of deferred/stream incremental data... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spec edits for merging defers at the same level, corresponding to graphql/graphql-js#3820