Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix --use-xpathhelper usage #328

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

miguelbf-alb
Copy link
Contributor

Pyangbind --use-xpath-helper is incorrectly mentioned in the usage documentation. The actual option is --use-xpathhelper. See implementation:

"--use-xpathhelper",

Also in xpathhelper docs the option is correctly named:

To initialise a YANGPathHelper class and use it with PyangBind-generated classes, the bindings must have been specified with the `--use-xpathhelper` argument. This ensures that the bindings are configured to pass the `path_helper` reference to one another as new classes are instantiated.

@JoseIgnacioTamayo
Copy link
Collaborator

LGTM, thanks for the documentation fix.

For some other reason the Unit Tests are failing, I will see to fix those tests and then this MR will go through.

@JoseIgnacioTamayo
Copy link
Collaborator

Could you please rebase to the lastest master, so the unit tests pass?

@miguelbf-alb
Copy link
Contributor Author

@JoseIgnacioTamayo done, thanks

@JoseIgnacioTamayo JoseIgnacioTamayo merged commit 1c7990f into robshakir:master Dec 1, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants