Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples for Iterable.toContain.atLeast #1545

Closed
2 tasks
robstoll opened this issue Sep 26, 2023 · 4 comments · Fixed by #1669
Closed
2 tasks

samples for Iterable.toContain.atLeast #1545

robstoll opened this issue Sep 26, 2023 · 4 comments · Fixed by #1669
Assignees
@fergbaldo
Labels
good first issue Good for newcomers help wanted
Milestone
1.2.0

Comments

@robstoll
Copy link
Owner

Code related feature

Following the things you need to do:

api-infix

  • add a atLeast method in IterableLikeToContainCheckerSamples (see CharSequenceToContainCheckerSamples
  • link in the KDoc of the corresponding function in iterableLikeToContainCheckers.kt to the sample via @sample (see charsequenceToContainCheckers.kt)

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@fergbaldo
Copy link

I'll work on this.
I'll start looking over how I can achieve this tomorrow and communicate if I have any issues or misunderstanding. Can I please be assigned to work on this? Thanks!

@fergbaldo
Copy link

Hi, just an update to let you know that I had to delay my first look at this contribution due to some personal issues but I should get a chance to either today or tomorrow. Thanks for the assignment

@robstoll
Copy link
Owner Author

no stress :)

fergbaldo pushed a commit to fergbaldo/atrium-mine that referenced this issue Oct 29, 2023
@u7498672
Solved issue "samples for Iterable.toContain.atLeast"
0e7a43c 
added atLeast method to IterableLikeToContainCheckerSamples.kt and added @sample annotation to the corresponding function's KDoc in iterableLikeToContainCheckers.kt

CI needs to ensured as passing upon submission of Pull Request

Resolves robstoll#1545
@fergbaldo fergbaldo mentioned this issue Oct 29, 2023
Closed
@fergbaldo
Copy link

fergbaldo commented Oct 29, 2023 •
edited
Loading

Hi @robstoll, I just uploaded a pull request for a possible solution to this issue.
Please review this and let me know if any changes need to be made. If no changes are required, then I can likely complete another couple of similar issues today.

I would like to note that the build for this project would produce consistent errors on my devices due to 'missing' temporary files, before and after my edits. As such, I produced this code after a study of other functional relevant code in the project.

This was referenced Oct 29, 2023
Closed
Closed
@robstoll robstoll modified the milestones: 1.1.0, 1.2.0 Oct 29, 2023
@robstoll robstoll linked a pull request Jan 20, 2024 that will close this issue
Improve/samples for Iterable.toContain.atLeast/butAtMost/atMost #1669
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fergbaldo fergbaldo

Labels
good first issue Good for newcomers help wanted
Projects
None yet
Milestone
1.2.0
2 participants
@robstoll @fergbaldo