Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build samples as composite build #245

Closed
11 tasks
robstoll opened this issue Oct 22, 2019 · 5 comments · Fixed by #471
Closed
11 tasks

Build samples as composite build #245

robstoll opened this issue Oct 22, 2019 · 5 comments · Fixed by #471
Assignees
Milestone

Comments

@robstoll
Copy link
Owner

robstoll commented Oct 22, 2019

Dev-op related feature

We have currently two js projects in /samples. It would be nice if we could create the projects as independent projects, like we did for samples/jvm/spek and samples/jvm/junit5. Meaning with an own settings.gradle, build.gradle and gradlew so that one can really just copy the project and immediately start.

Those projects have to use a published version of Atrium and cannot use the current development version.
However, it would be nice to know if the current development version still works for those sample projects.

Following the things you need to do:

  • setup a module in misc/tools/atrium-samples-test (add folder + include it in settings.gradle in root)
  • turn samples/js/jasmine into an independent project
    • remove it from settings.gradle in root
    • add own settings.gradle, gradle.build, gradlew etc. in this project
    • include it in the composite build
  • turn samples/js/mocha into an independent project
    • remove it from settings.gradle in root
    • add own settings.gradle, gradle.build, gradlew etc. in this project
    • include it in the composite build
  • search for TODO #245 and resolve them

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime,
    we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@iamshubh
Copy link
Contributor

Hey, assign it to me

@robstoll robstoll modified the milestone: 0.9.0 Oct 30, 2019
@robstoll
Copy link
Owner Author

@iamshubh do you need help?

@iamshubh
Copy link
Contributor

iamshubh commented Nov 19, 2019

@iamshubh do you need help?

Did not get time to look into it, will check this out!

@robstoll
Copy link
Owner Author

@iamshubh are you still working on it?

@assaflei
Copy link
Contributor

I'll would like to take this

assaflei added a commit to assaflei/atrium that referenced this issue Apr 24, 2020
assaflei added a commit to assaflei/atrium that referenced this issue Apr 24, 2020
robstoll added a commit that referenced this issue Apr 25, 2020
robstoll added a commit that referenced this issue Apr 25, 2020
@robstoll robstoll added this to the 0.12.0 milestone Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants