Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groovy to Kotlin script #1164

Merged
merged 2 commits into from
Jul 8, 2022
Merged

Groovy to Kotlin script #1164

merged 2 commits into from
Jul 8, 2022

Conversation

femialaka
Copy link
Contributor


I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.

I have changed the Gradle build file from groovy to Kotlin script.

@femialaka femialaka requested a review from robstoll as a code owner July 7, 2022 17:16
Copy link
Owner

@robstoll robstoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@femialaka please delete build.gradle and your file should be placed in atrium-js-test and be named build.gradle.kts and not build/gradle.kts (otherwise it looks good)

@femialaka
Copy link
Contributor Author

no problem

@femialaka
Copy link
Contributor Author

I presume you meant atrium-js-sample-test not atrium-js-test ?

Secondly, I am having problems loading the build files script configuration in IntelliJ.

load_script

This leads to a final out put of:

build_output

@robstoll
Copy link
Owner

robstoll commented Jul 8, 2022

@femialaka sorry, I meant atrium-js-sample-test. Do not worry to much about intellij, try if it works with:

cd misc/tools/atrium-js-sample-test
./gradlew build

@femialaka
Copy link
Contributor Author

The command line gave me the error "Unsupported class file major version 60", so I updated the SDK to 11 and it worked in IntelliJ

@robstoll robstoll merged commit 8df4d58 into robstoll:main Jul 8, 2022
@robstoll
Copy link
Owner

robstoll commented Jul 8, 2022

@femialaka thanks for your first contribution to Atrium 🙂 👍

Maybe another one?
https://github.com/robstoll/atrium/issues?q=is%3Aissue+is%3Aopen+label%3A%22help+wanted%22+no%3Aassignee

And don't forget to ⭐ Atrium if you liked it. Thanks

@femialaka
Copy link
Contributor Author

Ok no problem 😁

@robstoll robstoll added this to the 0.19.0 milestone Dec 29, 2022
@robstoll robstoll removed this from the 0.19.0 milestone Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rewrite misc/tools/atrium-js-sample-test/build.gradle to build.gradle.kts
2 participants