Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/tests report options map to contain #1692

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

robstoll
Copy link
Owner

resolves #1129


I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.

simonNozaki and others added 2 commits January 31, 2024 21:03
which also means fix the wrong tests written by snozaki in previous
commit
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (72a3891) 91.94% compared to head (eba19cb) 91.99%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1692      +/-   ##
============================================
+ Coverage     91.94%   91.99%   +0.04%     
  Complexity      114      114              
============================================
  Files           422      422              
  Lines          4621     4621              
  Branches        231      231              
============================================
+ Hits           4249     4251       +2     
+ Misses          325      323       -2     
  Partials         47       47              
Flag Coverage Δ
current 91.77% <ø> (+0.04%) ⬆️
current_windows 90.69% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robstoll robstoll merged commit 69170ad into main Jan 31, 2024
22 checks passed
@robstoll robstoll deleted the improve/tests-report-options-map-toContain branch January 31, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add tests for reportOptions to MapToContainInOrderOnlyKeyValueExpectationsSpec
2 participants