-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ‘@throws AssertionError’ KDoc from Assertion Functions #742
Conversation
ea27254
to
684229c
Compare
...-api-fluent-en_GB-common/src/main/kotlin/ch/tutteli/atrium/api/fluent/en_GB/anyAssertions.kt
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #742 +/- ##
=========================================
Coverage 87.93% 87.93%
Complexity 16 16
=========================================
Files 936 936
Lines 8412 8412
Branches 390 390
=========================================
Hits 7397 7397
Misses 940 940
Partials 75 75
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
7756d17
to
067410d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jGleitz I change my mind, sorry. I prefer if this commit does not contain changes to deprecated APIs, I am going to remove them in v0.16.0. Can you please revert those changes
Is it a problem if this does contain changes to deprecated APIs? I did all changes with search + replace. While it’s easy to roll that back for files of deprecated projects, finding all deprecated methods would be a lot of manual work. If those functions will be deleted anyway, why does it matter if we change them in this PR? |
It is enough to revert all changes in path misc/deprecated, you don't need to search for methods in api-fluent or api-infix. |
067410d
to
7a83fe9
Compare
sure, no problem! Done. |
core/api/atrium-core-api-common/src/main/kotlin/ch/tutteli/atrium/creating/AssertionHolder.kt
Outdated
Show resolved
Hide resolved
...core-api-common/src/main/kotlin/ch/tutteli/atrium/creating/AssertionPlantWithCommonFields.kt
Outdated
Show resolved
Hide resolved
core/api/atrium-core-api-common/src/main/kotlin/ch/tutteli/atrium/creating/Expect.kt
Outdated
Show resolved
Hide resolved
...um-core-api-common/src/main/kotlin/ch/tutteli/atrium/creating/ReportingAssertionContainer.kt
Outdated
Show resolved
Hide resolved
...mmon/src/main/kotlin/ch/tutteli/atrium/core/robstoll/lib/checking/FeatureAssertionChecker.kt
Outdated
Show resolved
Hide resolved
7a83fe9
to
831d279
Compare
Fixed the problems myself. Thanks for the PR 🙂, looking forward to the others |
As discussed in #714, those docs where too vague to be actually helpful.